Repository navigation
Raise unit test coverage from 49% to 81% - #49
Merged
Merged
Conversation
- Add tests for Circle, GroundOverlay, TileOverlay, Tile, the Options builders, PredefinedTileProviders and the public Projection class - Add MapControllerOverlaysTest for circles, ground and tile overlays, their touch detection, info windows and drawing every shape type - Remove five private draw helpers in MapController that were never called (replaced earlier by the zIndex-aware versions) - Raise the coverage gate from 20% to 75% - Update the test table in TESTING_UNIT.md with current counts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit test coverage was at 49% of instructions (38% of branches), and the gate only required 20%. Several public classes had no tests at all: Circle, GroundOverlay, TileOverlay, every *Options builder, PredefinedTileProviders and the Projection class.
What's in here:
Result: 81% instructions, 79% lines, 65% branches. The biggest remaining gap is OpenMapView itself (23%), mostly touch handling, which the instrumented tests exercise on a device instead.
Merges cleanly with #48, which touches the same script.